Merged
Conversation
Contributor
|
I would add a search term so people know how to find it in the logs. |
PlasmaPower
approved these changes
May 30, 2017
Contributor
Author
|
@PlasmaPower you also have to react/comment 👍 in order @chaosbot to consider your vote -- the meritocracy commit made it so reviews only satisfy the meritocracy, not act as a vote. |
Contributor
|
@Smittyvb Yeah I forgot to vote. Both are done now. |
phil-r
approved these changes
May 30, 2017
Contributor
|
@phil-r did it work? |
Member
|
@PlasmaPower I was just checking API resonses to review #396 |
Contributor
|
@phil-r are they ordered correctly? |
Member
|
@PlasmaPower last one at the bottom |
Contributor
|
Great! |
Collaborator
|
🙆♀️ PR passed with a vote of 16 for and 0 against, a weighted total of 15.5 and a threshold of 6.5, and a current meritocracy review. See merge-commit ddfdb84 for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the text "chaosbot's logs" in the README a link to the logs, where people can find the meritocracy information.