feat(dissector): add more derived values for current demand #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chardin-cpi
force-pushed
the
ckhardin/wip-dissector-limits
branch
10 times, most recently
from
5ff77ac
to
087958d
Compare
The struct breakout of the physical values as a Multipler, Value, Unit is not conducive to graphing or columns. So, derived more of the values like the limits on current, voltage, power as a computed double to make the presentation a bit easier. Fixes #50 Signed-off-by: Charles Hardin <charles.hardin@chargepoint.com>
chardin-cpi
force-pushed
the
ckhardin/wip-dissector-limits
branch
from
087958d
to
b519fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct breakout of the physical values as a Multipler, Value, Unit is not conducive to graphing or columns. So, derived more of the values like the limits on current, voltage, power as a computed double to make the presentation a bit easier.
Fixes #50