Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation form fails HTML validation #344

Closed
ericnicolaas opened this issue Jun 22, 2017 · 0 comments

Comments

@ericnicolaas
Copy link
Contributor

commented Jun 22, 2017

There are a variety of errors and warnings cropping up on the donation form. Errors:

  • The “label” element may contain at most one “button”, “input”, “meter”, “output”, “progress”, “select”, or “textarea” descendant.
  • “label” element with multiple labelable descendants.
  • Any “input” descendant of a “label” element with a “for” attribute must have an ID value that matches that “for” attribute.
  • The “for” attribute of the “label” element must refer to a non-hidden form control.

These are the four that refer to elements added by Charitable.

@ericnicolaas ericnicolaas added the bug label Jun 22, 2017

@ericnicolaas ericnicolaas added this to the 1.4.18 milestone Jun 22, 2017

ericnicolaas added a commit that referenced this issue Jun 29, 2017
Attempting to fix all the issues caused by mismatched labels and fiel…
…ds. Also working on better accessibility with multi-input fields like radio lists, checkbox lists and credit card expiration selects. See #344.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.