Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid resending emails that have already been sent #96

Closed
ericnicolaas opened this issue Feb 12, 2016 · 0 comments

Comments

@ericnicolaas
Copy link
Contributor

commented Feb 12, 2016

When a donation is changed from Paid to Pending and then back to Paid, the donation receipt & admin notification will be sent twice.

When an email is sent, it should be logged. There are a few options:

  1. Add it to the _donation_log meta. Disadvantage of this is that this log isn't that easy to search.
  2. Add it to a separate meta field. Disadvantage of this is that we're adding to the meta table even more.

The latter is definitely a quick, easy approach. If we combine it with a future approach to revamp how logs are stored (as comments instead of meta), I think this is fine. We should probably store the timestamp as the meta value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.