fix: Legend options configuration has no effect#136
Merged
Conversation
…not create legend if option.legend.show is false.
Member
|
Wth. I have no idea why the PR closed. Reopened and pushed a commit for a super tiny formatting change, but it is good to go. Excellent job finding this!! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Values provided in
options.legendwere not applied.Minimal example
Type of Change
Related Issues
Testing
Given the simplicity of the change, the behavior was verified through manual testing.
examples/(when behavior changes)Documentation
I noticed that these options are not documented in
docs/api/options.md.I assumed they are intended to be public since they are already supported by the API, but please let me know if this behavior is not meant to be exposed yet.
docs/when public API or behavior changesCHANGELOG.mdwhen public behavior changesWebGPU Correctness
queue.writeBuffer()calls use 4-byte aligned offsets and sizesminUniformBufferOffsetAlignment(if applicable)buffer.destroy(),device.destroy(), etc.)Browser Testing Checklist
Screenshots / Videos
With

show: false:With

position: "bottom":Performance Impact
Given the simplicity of the change, I doubt there will be an impact.
Additional Notes
Although it would be preferable for the top and bottom positions to reserve the correct amount of space to avoid overlapping the plot, this can be easily mitigated by adjusting the grid margins.
For Reviewers: