New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdlib and use include apt rather than declare #448

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@roborourke
Contributor

roborourke commented Sep 11, 2017

This is to support some more modern modules - I ran into the following issues:

Error: Unknown function validate_integer at /vagrant/extensions

Updating stdlib to 4.19.0 removed that issue, resolved after 4.15.0 as far as I can tell.

Next issue:

Error: Duplicate declaration: Class[Apt] is already declared; ... in ... development.pp

Resolved by changing class { 'apt': } to include apt.

Would be good to test the knock on effect of this on some the more popular extensions first I think, plus maybe some of the other modules could be updated at the same time.

@BronsonQuick BronsonQuick requested a review from rmccue Sep 11, 2017

@BronsonQuick BronsonQuick self-requested a review Sep 20, 2017

@BronsonQuick

I've just tested this with the following list of extensions:

# Install a list of extensions automatically
extensions:
  - chassis/tester
  - chassis/xdebug
  - chassis/mailhog
  - chassis/gutenberg
  - chassis/npm
  - chassis/imagick
  - chassis/cavalcade
  - chassis/sequelpro
  - chassis/tester
  - chassis/phpcs
  - chassis/phpini
  - chassis/grunt
  - chassis/bbpress
  - chassis/yarn
  - chassis/gulp
  - chassis/vip-classic
  - chassis/phpmyadmin
  - chassis/webgrind
  - chassis/memcache
  - chassis/mcrypt
  - chassis/bower
  - chassis/fish
  - chassis/nodejs
  - chassis/composer
  - chassis/gmagick
  - chassis/db-backup

They all still work as expected so I'm happy to merge this now. Thanks @roborourke!

@BronsonQuick BronsonQuick merged commit 28a2b55 into Chassis:master Sep 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@roborourke

This comment has been minimized.

Show comment
Hide comment
@roborourke

roborourke Sep 20, 2017

Contributor
Contributor

roborourke commented Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment