New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-node 7.0 breaking change: Skip `files` by default #1383

Closed
huan opened this Issue Jun 24, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@huan
Copy link
Member

huan commented Jun 24, 2018

Which caused our src/typings.d.ts did not load when running tests.

Might have other bugs, will continue monitoring it.

See: https://github.com/TypeStrong/ts-node/releases/tag/v7.0.0

Update

According to https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html, reference typings.d.ts in config.ts could solve this issue better(with the benefits of the speed improvement of ts-node v7).

@huan huan added the bug label Jun 24, 2018

huan added a commit that referenced this issue Jun 24, 2018

@huan huan closed this Jun 24, 2018

@lijiarui

This comment has been minimized.

Copy link
Member

lijiarui commented Jun 24, 2018

How to fix this? I pull the latest version:

 1. Wechaty version: 0.17.14
  2. Linux x64 version 3.16.0-4-amd64 memory 10514/15072 MB
  3. Docker: true
  4. Node version: v10.5.0
  5. Tcp IPC TEST: PASS

But error still exist..

@lijiarui lijiarui reopened this Jun 24, 2018

@huan

This comment has been minimized.

Copy link
Member

huan commented Jun 24, 2018

It's a pity that you still do not understand how important of providing the reproduce steps with the logs in detail. sad.

@huan

This comment has been minimized.

Copy link
Member

huan commented Jun 27, 2018

@lijiarui Could you please confirm whether this issue is resolved?

If it did, please close this issue.
If it did not, please provide reproduce steps, and any workaround and pr fix is welcome.

@lijiarui lijiarui closed this Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment