New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic install puppet implementations instead of pre-install #1437

Closed
huan opened this Issue Jul 2, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@huan
Copy link
Member

huan commented Jul 2, 2018

In order to support WECHATY_PUPPET=xxx environment, we need to be able to load the specific puppet at runtime.

Currently, we pre-installed PuppetPadchat, PuppetPuppeteer, PuppetWechat4u, PuppetMock to import into our puppet-config.ts.

However, sometimes it's unnecessary to install all of them because we only use one or two of them.

So it will be better to install them when be required.

I believe NPM should be programmed to do this job.

To Be Investigated.

@huan huan added the enhancement label Jul 2, 2018

huan added a commit that referenced this issue Jul 5, 2018

huan added a commit that referenced this issue Jul 5, 2018

@huan

This comment has been minimized.

Copy link
Member

huan commented Jul 5, 2018

Done.

@huan huan closed this Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment