New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room.alias() should return null if we have not set the alias in the room #283

Closed
zixia opened this Issue Feb 25, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@zixia
Member

zixia commented Feb 25, 2017

Now it will return self name if no alias found . It's not right and need to be fixed.

@zixia zixia assigned zixia and lijiarui and unassigned zixia Feb 25, 2017

@zixia zixia added the bug label Feb 25, 2017

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Feb 28, 2017

Member

after you merged #275 I will fix this one.

Member

lijiarui commented Feb 28, 2017

after you merged #275 I will fix this one.

lijiarui added a commit to lijiarui/wechaty that referenced this issue Mar 7, 2017

zixia added a commit that referenced this issue Mar 11, 2017

#283 (#303)
* #283

* add jsDoc

@lijiarui lijiarui referenced this issue Mar 11, 2017

Merged

#283 #303

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 12, 2017

Member

Thanks @lijiarui for fixing this.

Member

zixia commented Mar 12, 2017

Thanks @lijiarui for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment