New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room.member() cannot find contact correctly #365

Closed
lijiarui opened this Issue Mar 27, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@lijiarui
Member

lijiarui commented Mar 27, 2017

Bug: When the bot set alias for a contact, using function room.member({name: name}) cannot get the contact.

What's more, if there are two contacts has the same name in one room, room.member() cannot get the correct contact.

So, I have the following suggestion:

  • add function room.memberAll():Contact[] correspond to room.member(): Contact. Using function memberAll() can get all the matches contacts.
  • change room.member(query) query to the following three types:
    • name: find the contact by wechat name in a room.
    • roomAlias: find the contact by alias set by the contact in a room.
    • contactAlias: find the contact by alias set by the bot in a room.

Related issues: #334 #173 #217

@lijiarui

This comment has been minimized.

Member

lijiarui commented Apr 5, 2017

fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment