New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat.avatar() faild ,when hostname changed from https://wx.qq.com to https://wx2.qq.com #418

Closed
ghost opened this Issue Apr 19, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Apr 19, 2017

Sometimes when I login wechat ,the hostname changed and Concat.avatar() wouldn't work.
I found that the host in the broswer is "https://wx2.qq.com" ,and in method Concat.avatar() "avatarUrl = https://wx.qq.com/xxxxxxx" . maybe something wrong here.

In the source code , cookie.hostname() default valued "http://wx.qq.com" ,and will not changed after first login wechat ,no matter what the real hostname is.

@zixia zixia added the bug label Apr 19, 2017

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Apr 19, 2017

Member

Thanks for reporting this.

I think we should consider a new method like PuppetWebBrowser.hostname(), which can get current hostname that the web wechat is running on.

Member

zixia commented Apr 19, 2017

Thanks for reporting this.

I think we should consider a new method like PuppetWebBrowser.hostname(), which can get current hostname that the web wechat is running on.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Jun 19, 2017

Member

I have changed the hostname() function to get the current domain from the Browser since v0.8.110.

This issue should not exist anymore, but it needs to be confirmed.

@iRabbit @jinliming2 @kk3hi3123 Could you help me to test that?

Member

zixia commented Jun 19, 2017

I have changed the hostname() function to get the current domain from the Browser since v0.8.110.

This issue should not exist anymore, but it needs to be confirmed.

@iRabbit @jinliming2 @kk3hi3123 Could you help me to test that?

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Jul 6, 2017

Member

Close this issue due to no response for more than two weeks.

Member

zixia commented Jul 6, 2017

Close this issue due to no response for more than two weeks.

@zixia zixia closed this Jul 6, 2017

keepgoingwm added a commit to keepgoingwm/wechaty that referenced this issue Jul 19, 2017

Merge branch 'master' of https://github.com/Chatie/wechaty
* 'master' of https://github.com/Chatie/wechaty: (451 commits)
  0.8.110
  fix(typescript): add dependencies for @types. Chatie#136 (comment) (Chatie#136)
  0.8.109
  0.8.108
  add(source): add TypeScript source to npm package for source map
  chore(package): update @types/express to version 4.0.36 (Chatie#583)
  chore(package): update @types/mime to version 1.3.0 (Chatie#584)
  chore(package): update @types/request to version 0.0.44 (Chatie#585)
  chore(package): remove unused dependiences: is-ci / is-docker
  0.8.107
  fix(process.env): should use `[` instead of `(`! (Chatie#582)
  0.8.106
  clean(code): rename `Config` to `config`, change `wechaty.version()` to static compitibal
  clean(code): identify Docker environment by ENV variable. (Chatie#84)
  0.8.105
  fix Chatie#581
  0.8.104
  fix(test): use stable domain to test cookie.(Chatie#579)
  update(hostname): get current domain from webdriver to make hostname always right.(Chatie#418)
  update(changelog)
  ...

# Conflicts:
#	.gitignore
#	src/puppet-web/watchdog.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment