New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance #155 fire `room-join` when someone joins from a QR Code #162

Merged
merged 8 commits into from Jan 2, 2017

Conversation

Projects
None yet
3 participants
@lijiarui
Member

lijiarui commented Dec 24, 2016

@zixia

Looks good.

Please also add the new function/message to unit test in file firer.spec.ts

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Dec 24, 2016

Member

Done

And add . in regexConfig.roomJoinQrcode

Member

lijiarui commented Dec 24, 2016

Done

And add . in regexConfig.roomJoinQrcode

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Dec 24, 2016

Member

It seems your test is failed:

  × src » puppet-web » firer » parseRoomJoin() Error: checkRoomJoin() not found matched re of "桔小秘" joined the group chat via your shared QR Code.

Please fix.

Member

zixia commented Dec 24, 2016

It seems your test is failed:

  × src » puppet-web » firer » parseRoomJoin() Error: checkRoomJoin() not found matched re of "桔小秘" joined the group chat via your shared QR Code.

Please fix.

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Dec 24, 2016

Member

It seems fix...

Member

lijiarui commented Dec 24, 2016

It seems fix...

@zixia

zixia approved these changes Dec 25, 2016

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Dec 25, 2016

Member

LGTM

@dcsan this PR is related to your issue #155, could please confirm that it provide the feature you want?

Member

zixia commented Dec 25, 2016

LGTM

@dcsan this PR is related to your issue #155, could please confirm that it provide the feature you want?

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Dec 25, 2016

Member

Please choose this one, it can identify the inviter in a right way.

Member

lijiarui commented Dec 25, 2016

Please choose this one, it can identify the inviter in a right way.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Dec 28, 2016

Member

@dcsan could you have a look on this PR? :)

Member

zixia commented Dec 28, 2016

@dcsan could you have a look on this PR? :)

@dcsan

This comment has been minimized.

Show comment
Hide comment
@dcsan

dcsan Dec 28, 2016

yep I will... by friday

dcsan commented Dec 28, 2016

yep I will... by friday

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Jan 2, 2017

Member

#155 (comment)

@dcsan Thanks for your review & test.

Member

zixia commented Jan 2, 2017

#155 (comment)

@dcsan Thanks for your review & test.

@zixia zixia merged commit 3c1517f into Chatie:master Jan 2, 2017

1 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
security/snyk No new vulnerabilities
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment