New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the nick/remark/display for contact/room #217 #234

Merged
merged 6 commits into from Feb 8, 2017

Conversation

Projects
None yet
3 participants
@lijiarui
Member

lijiarui commented Feb 6, 2017

No description provided.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 6, 2017

Coverage Status

Coverage decreased (-0.2%) to 55.733% when pulling 39e1955 on lijiarui:217 into ee51219 on wechaty:master.

coveralls commented Feb 6, 2017

Coverage Status

Coverage decreased (-0.2%) to 55.733% when pulling 39e1955 on lijiarui:217 into ee51219 on wechaty:master.

1 similar comment
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 6, 2017

Coverage Status

Coverage decreased (-0.2%) to 55.733% when pulling 39e1955 on lijiarui:217 into ee51219 on wechaty:master.

coveralls commented Feb 6, 2017

Coverage Status

Coverage decreased (-0.2%) to 55.733% when pulling 39e1955 on lijiarui:217 into ee51219 on wechaty:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 6, 2017

Coverage Status

Coverage decreased (-0.002%) to 55.886% when pulling c0a6998 on lijiarui:217 into ee51219 on wechaty:master.

coveralls commented Feb 6, 2017

Coverage Status

Coverage decreased (-0.002%) to 55.886% when pulling c0a6998 on lijiarui:217 into ee51219 on wechaty:master.

1 similar comment
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 6, 2017

Coverage Status

Coverage decreased (-0.002%) to 55.886% when pulling c0a6998 on lijiarui:217 into ee51219 on wechaty:master.

coveralls commented Feb 6, 2017

Coverage Status

Coverage decreased (-0.002%) to 55.886% when pulling c0a6998 on lijiarui:217 into ee51219 on wechaty:master.

@zixia

Please follow my change requests.

Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 6, 2017

Coverage Status

Coverage decreased (-0.02%) to 55.873% when pulling 1b88912 on lijiarui:217 into ee51219 on wechaty:master.

coveralls commented Feb 6, 2017

Coverage Status

Coverage decreased (-0.02%) to 55.873% when pulling 1b88912 on lijiarui:217 into ee51219 on wechaty:master.

@zixia

Good, please follow my new reviews.

Also, please make sure the test coverage is not decreasing. last time your PR caused a coverage decrease:

Coverage decreased (-0.002%) to 55.886% when pulling c0a6998 on lijiarui:217 into ee51219
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Feb 6, 2017

Member

I guess Coverage decrease because I deleted const name2 = r.name(contact2) in room.spec.ts, because it is a wrong function caused by me in the first commit.

I'm sorry in my first commit I add a wrong function Room.name(contact), but after read your request, I changed function name() into alias().

Member

lijiarui commented Feb 6, 2017

I guess Coverage decrease because I deleted const name2 = r.name(contact2) in room.spec.ts, because it is a wrong function caused by me in the first commit.

I'm sorry in my first commit I add a wrong function Room.name(contact), but after read your request, I changed function name() into alias().

1
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 7, 2017

Coverage Status

Coverage decreased (-0.05%) to 55.836% when pulling 04987d0 on lijiarui:217 into ee51219 on wechaty:master.

coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.05%) to 55.836% when pulling 04987d0 on lijiarui:217 into ee51219 on wechaty:master.

@zixia

There's part of code is confusing me a lot.

Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
2
@zixia

Almost merage-able.

Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/contact.ts Outdated
3

@zixia zixia merged commit 03d3991 into Chatie:master Feb 8, 2017

2 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
security/snyk No new vulnerabilities
Details

@lijiarui lijiarui deleted the lijiarui:217 branch Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment