New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#291 change `throw error` to `return null` #292

Merged
merged 3 commits into from Mar 11, 2017

Conversation

Projects
None yet
2 participants
@lijiarui
Member

lijiarui commented Mar 2, 2017

#291
if Contact&Room cannot find, function fnd() return null

@zixia

doc should also be modified in sync.

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Mar 11, 2017

Member

@zixia added jsDoc as you required

Member

lijiarui commented Mar 11, 2017

@zixia added jsDoc as you required

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 11, 2017

Member

Thanks!

Member

zixia commented Mar 11, 2017

Thanks!

@zixia zixia merged commit 92800c2 into Chatie:master Mar 11, 2017

1 check passed

codacy/pr Good work! A positive pull request.
Details
@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui
Member

lijiarui commented Mar 11, 2017

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Mar 11, 2017

Member

After merged this one, the following code doesn't work

example/gist-bot/on-friend.ts(34,9): error TS2531: Object is possibly 'null'.
example/gist-bot/on-friend.ts(35,9): error TS2531: Object is possibly 'null'.
example/gist-bot/on-message.ts(40,11): error TS2531: Object is possibly 'null'.
example/gist-bot/on-message.ts(46,7): error TS2531: Object is possibly 'null'.
Member

lijiarui commented Mar 11, 2017

After merged this one, the following code doesn't work

example/gist-bot/on-friend.ts(34,9): error TS2531: Object is possibly 'null'.
example/gist-bot/on-friend.ts(35,9): error TS2531: Object is possibly 'null'.
example/gist-bot/on-message.ts(40,11): error TS2531: Object is possibly 'null'.
example/gist-bot/on-message.ts(46,7): error TS2531: Object is possibly 'null'.
@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 11, 2017

Member

Then fix it please.

Member

zixia commented Mar 11, 2017

Then fix it please.

@lijiarui lijiarui referenced this pull request Mar 11, 2017

Merged

291 #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment