New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#283 #303

Merged
merged 3 commits into from Mar 11, 2017

Conversation

Projects
None yet
2 participants
@lijiarui
Member

lijiarui commented Mar 7, 2017

let room.alias() return null when not set roomAlias

@zixia

Please also sync(add) JSDoc for the modified function.

@@ -222,7 +222,7 @@ export class Room extends EventEmitter implements Sayable {
tmpName = contact.alias() || contact.name()
break
case 'alias':
tmpName = member.DisplayName || contact.name()
tmpName = member.DisplayName

This comment has been minimized.

@zixia

zixia Mar 7, 2017

Member
@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 11, 2017

Member

Thanks.

Member

zixia commented Mar 11, 2017

Thanks.

@zixia zixia merged commit ee01871 into Chatie:master Mar 11, 2017

1 check passed

codacy/pr Good work! A positive pull request.
Details
@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui
Member

lijiarui commented Mar 11, 2017

fix #283

@lijiarui lijiarui deleted the lijiarui:283 branch Mar 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment