New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove m.send() fucntion #323

Merged
merged 4 commits into from Mar 18, 2017

Conversation

Projects
None yet
3 participants
@lijiarui
Member

lijiarui commented Mar 13, 2017

No description provided.

@zixia

Please consider more situations to improve the code quality.

Show outdated Hide outdated example/friend-bot.ts Outdated

@lijiarui lijiarui closed this Mar 17, 2017

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 17, 2017

Member

@lijiarui Please leave a comment for noting the reason before close a PR/ISSUE.

Member

zixia commented Mar 17, 2017

@lijiarui Please leave a comment for noting the reason before close a PR/ISSUE.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 17, 2017

Member

I'm a little bit disappointed for your giving up so easy, without trying harder.

You could do it to replace msg.to('filehelper') very easy by this:

const fileTransfer = Contact.load('filehelper')
Member

zixia commented Mar 17, 2017

I'm a little bit disappointed for your giving up so easy, without trying harder.

You could do it to replace msg.to('filehelper') very easy by this:

const fileTransfer = Contact.load('filehelper')

@lijiarui lijiarui reopened this Mar 18, 2017

@zixia

Your last commit message is a typo.

Ugly.

Show outdated Hide outdated example/friend-bot.ts Outdated
Show outdated Hide outdated example/friend-bot.ts Outdated
Show outdated Hide outdated example/friend-bot.ts Outdated

lijiarui added some commits Mar 18, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

coveralls commented Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

coveralls commented Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

coveralls commented Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

coveralls commented Mar 18, 2017

Coverage Status

Changes Unknown when pulling 6a02c22 on lijiarui:send into ** on Chatie:master**.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 18, 2017

Member

it's so easy ha?

i hope you could learn from this that a good collaborator should think more, talk less and do the exact what you need to do.

Member

zixia commented Mar 18, 2017

it's so easy ha?

i hope you could learn from this that a good collaborator should think more, talk less and do the exact what you need to do.

@zixia zixia merged commit fdae034 into Chatie:master Mar 18, 2017

4 of 6 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls First build on master at 55.769%
Details
security/snyk No new vulnerabilities
Details
@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Mar 18, 2017

Member

Thanks

Member

lijiarui commented Mar 18, 2017

Thanks

@lijiarui lijiarui deleted the lijiarui:send branch Mar 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment