New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first item of memberList as owner is confusion #358

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
3 participants
@JasLin
Contributor

JasLin commented Mar 24, 2017

  1. in wxwebapp,first item in memberList is a random user from the room ,it's confusion,
  2. some times we can got owneruin or ChatRoomOwner .

as those reason, first member from memberlist should not be here any more

JasLin and others added some commits Mar 24, 2017

Merge pull request #5 from Chatie/master
upgrade to  latest code
jas@mac
1. in wxwebapp,first item in memberList is a random user from the roo…
…m, 2. some times we can got owneruin or ChatRoomOwner . as those reason, first member from memberlist should not be here any more
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 24, 2017

Coverage Status

Coverage decreased (-0.02%) to 56.496% when pulling 22d6c39 on JasLin:master into f76d72c on Chatie:master.

coveralls commented Mar 24, 2017

Coverage Status

Coverage decreased (-0.02%) to 56.496% when pulling 22d6c39 on JasLin:master into f76d72c on Chatie:master.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 24, 2017

Member

Thanks bro, you are right.

Member

zixia commented Mar 24, 2017

Thanks bro, you are right.

@zixia zixia merged commit 88f9833 into Chatie:master Mar 24, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.02%) to 56.496%
Details
security/snyk No new vulnerabilities
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment