New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the size of the sending file #376

Merged
merged 6 commits into from Mar 31, 2017

Conversation

Projects
None yet
3 participants
@mukaiu
Contributor

mukaiu commented Mar 30, 2017

Wechat web limits the file size to 20M

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 30, 2017

Coverage Status

Changes Unknown when pulling 389af62 on mukaiu:limit_file_size into ** on Chatie:master**.

coveralls commented Mar 30, 2017

Coverage Status

Changes Unknown when pulling 389af62 on mukaiu:limit_file_size into ** on Chatie:master**.

@zixia

You are very efficient, thanks!

Show outdated Hide outdated src/puppet-web/puppet-web.ts Outdated
Show outdated Hide outdated src/puppet-web/puppet-web.ts Outdated

mukaiu added some commits Mar 31, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 31, 2017

Coverage Status

Changes Unknown when pulling 0f74cbe on mukaiu:limit_file_size into ** on Chatie:master**.

coveralls commented Mar 31, 2017

Coverage Status

Changes Unknown when pulling 0f74cbe on mukaiu:limit_file_size into ** on Chatie:master**.

1 similar comment
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 31, 2017

Coverage Status

Changes Unknown when pulling 0f74cbe on mukaiu:limit_file_size into ** on Chatie:master**.

coveralls commented Mar 31, 2017

Coverage Status

Changes Unknown when pulling 0f74cbe on mukaiu:limit_file_size into ** on Chatie:master**.

@zixia

Thanks.

Show outdated Hide outdated src/puppet-web/puppet-web.ts Outdated
Show outdated Hide outdated src/puppet-web/puppet-web.ts Outdated
@mukaiu

This comment has been minimized.

Show comment
Hide comment
@mukaiu

mukaiu Mar 31, 2017

Contributor

My code details need to be optimized😄😄😄

Contributor

mukaiu commented Mar 31, 2017

My code details need to be optimized😄😄😄

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 31, 2017

Member

Great, thanks!

Member

zixia commented Mar 31, 2017

Great, thanks!

@zixia

zixia approved these changes Mar 31, 2017

@zixia zixia merged commit a59984e into Chatie:master Mar 31, 2017

1 of 5 checks passed

ci/circleci CircleCI is running your tests
Details
codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
security/snyk No new vulnerabilities
Details

@mukaiu mukaiu deleted the mukaiu:limit_file_size branch Mar 31, 2017

@mukaiu mukaiu restored the mukaiu:limit_file_size branch Mar 31, 2017

zixia added a commit that referenced this pull request Mar 31, 2017

fix jsdoc flush issue #378 and minor fix on the doc examples (#380)
* fix Upcase

* use .alias() instead of .remark() 

contact.remark() should be deprecated

* fix Upcase

* use .alias() instead of .remark() 

contact.remark() should be deprecated

* fix the embeded doc for .alias()

* fix trailing whitespace

* Limit the size of the sending file (#376)

* Limit the size of the sending file

* limit vedio size

* add remark

* tslint

* Optimize videoMaxSize limit

* tslint

* fix Upcase

* use .alias() instead of .remark() 

contact.remark() should be deprecated

* fix the embeded doc for .alias()

* fix trailing whitespace

* remove  unnecessary comments in the exmaple code

* better example code

* Set / Get / Delete => SET / GET /DELETE

* better delete alias example

* Revert "Limit the size of the sending file (#376)"

This reverts commit a59984e.

@mukaiu mukaiu deleted the mukaiu:limit_file_size branch Apr 5, 2017

@mukaiu mukaiu restored the mukaiu:limit_file_size branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment