New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #512 #531

Merged
merged 1 commit into from May 20, 2017

Conversation

Projects
None yet
3 participants
@FlyingBlazer
Contributor

FlyingBlazer commented May 20, 2017

this is a simple syntax error when using arrow function

you need to use return when using {} in arrow function

see http://es6.ruanyifeng.com/#docs/function#箭头函数 for syntax reference

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui May 20, 2017

Member

yes, you are right, thanks for your request, please see my latest pr: #514

It can works well now.

Member

lijiarui commented May 20, 2017

yes, you are right, thanks for your request, please see my latest pr: #514

It can works well now.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia May 20, 2017

Member

@FlyingBlazer Good catch!

Thank you for pointing this out and make the PR.

Member

zixia commented May 20, 2017

@FlyingBlazer Good catch!

Thank you for pointing this out and make the PR.

@zixia zixia merged commit f3f5425 into Chatie:master May 20, 2017

3 of 6 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codacy/pr Good work! A positive pull request.
Details
codeclimate no new or fixed issues
Details
security/snyk No new vulnerabilities
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment