New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #623 #627

Merged
merged 3 commits into from Jul 2, 2017

Conversation

Projects
None yet
3 participants
@lijiarui
Member

lijiarui commented Jul 1, 2017

fix #623
delete setTimeout
modify mock_room error

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 1, 2017

Coverage Status

Changes Unknown when pulling 6726850 on lijiarui:testMessage into ** on Chatie:master**.

coveralls commented Jul 1, 2017

Coverage Status

Changes Unknown when pulling 6726850 on lijiarui:testMessage into ** on Chatie:master**.

@zixia

You need to make an additional change as the following diff:

- test.skip('mentioned()', async t => { 
+ test.serial('mentioned()', async t => { 

at https://github.com/lijiarui/wechaty/blob/67268503df0266941e6d1f23ef6d3ec8fe029df3/src/message.spec.ts#L147

Because your test is skipped now, which means not tested at all.

After you restored it, make sure your new PR can pass at least one CI test.

lijiarui added some commits Jul 2, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 2, 2017

Coverage Status

Changes Unknown when pulling e6a56f2 on lijiarui:testMessage into ** on Chatie:master**.

coveralls commented Jul 2, 2017

Coverage Status

Changes Unknown when pulling e6a56f2 on lijiarui:testMessage into ** on Chatie:master**.

@zixia zixia merged commit c48ec0a into Chatie:master Jul 2, 2017

6 of 7 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 54.21%
Details
security/snyk No new vulnerabilities
Details
@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Jul 2, 2017

Member

Looks good.

Could explain the reason of the failure before?

Member

zixia commented Jul 2, 2017

Looks good.

Could explain the reason of the failure before?

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Jul 3, 2017

Member

mock room_data shouldn't be room.rawObj, we should mock data structure as room.spec.ts do, but actual data should use room.rawObj.

I'm not sure where room.spec.ts's mock data structure from.

Member

lijiarui commented Jul 3, 2017

mock room_data shouldn't be room.rawObj, we should mock data structure as room.spec.ts do, but actual data should use room.rawObj.

I'm not sure where room.spec.ts's mock data structure from.

@lijiarui lijiarui deleted the lijiarui:testMessage branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment