New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

room-join cannot detect inviteeList when people join in the room with qrcode #651

Merged
merged 4 commits into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@lijiarui
Member

lijiarui commented Jul 12, 2017

#248
room-join cannot detect inviteeList when people join in the room with QR code:

  • If one contact joins in the room by the QR code shared by the bot, system message as follows:

    • "李佳芮" joined the group chat via your shared QR Code.
    • "李佳芮"通过扫描你分享的二维码加入群聊
  • If one contact joins in the room isn't by the QRcode shared by the bot, system message as follows:

    • " 李佳芮" joined the group chat via your shared QR Code.
    • " 李佳芮"通过扫描你分享的二维码加入群聊
      (Pay attention that it has more space before 李佳芮)

lijiarui added some commits Jul 12, 2017

@zixia

Please explain your changes.

Show outdated Hide outdated src/puppet-web/firer.ts Outdated
Show outdated Hide outdated src/puppet-web/firer.ts Outdated

lijiarui added some commits Jul 13, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 13, 2017

Coverage Status

Coverage remained the same at 54.647% when pulling d914328 on lijiarui:qrcodeBug into 1830cb3 on Chatie:master.

coveralls commented Jul 13, 2017

Coverage Status

Coverage remained the same at 54.647% when pulling d914328 on lijiarui:qrcodeBug into 1830cb3 on Chatie:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 13, 2017

Coverage Status

Coverage remained the same at 54.647% when pulling d914328 on lijiarui:qrcodeBug into 1830cb3 on Chatie:master.

coveralls commented Jul 13, 2017

Coverage Status

Coverage remained the same at 54.647% when pulling d914328 on lijiarui:qrcodeBug into 1830cb3 on Chatie:master.

@zixia zixia merged commit adcb6de into Chatie:master Jul 13, 2017

5 of 7 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 54.647%
Details
security/snyk No new vulnerabilities
Details
@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Jul 13, 2017

Member

Thanks

Member

zixia commented Jul 13, 2017

Thanks

@lijiarui lijiarui deleted the lijiarui:qrcodeBug branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment