New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: replace `document.domain` with `location.hostname` since front one sometimes lose subdomain name #770

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
2 participants
@zhenyong

zhenyong commented Aug 30, 2017

2017-08-30 11 42 18

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Aug 30, 2017

Member

Thanks for catching that!

I searched and find that someone said:

Do not use window.document.domain as it is not supported consistently.
at zeroclipboard/zeroclipboard#535

It seems we should switch to use location.hostname as you purposed.

Member

zixia commented Aug 30, 2017

Thanks for catching that!

I searched and find that someone said:

Do not use window.document.domain as it is not supported consistently.
at zeroclipboard/zeroclipboard#535

It seems we should switch to use location.hostname as you purposed.

@zixia zixia added the bug label Aug 30, 2017

@zixia zixia merged commit db3c2bb into Chatie:master Aug 30, 2017

6 of 7 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 55.561%
Details
security/snyk No new vulnerabilities
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment