New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change doc order # 774 #798

Merged
merged 5 commits into from Sep 15, 2017

Conversation

Projects
None yet
2 participants
@lijiarui
Member

lijiarui commented Sep 12, 2017

#774

  • tune the order of APIs
  • change the links inside README.md from Wiki to /docs/index.md
  • @private all deprecated APIs.

Next step: After you merge this, I will add friend request doc

@zixia

Please:

  1. Do not include unrelated changes.
  2. Divide this PR into two: one for README, one for the code.
  3. Make sure you are just moving code blocks, without make any additional modifications.

Thanks.

Show outdated Hide outdated src/wechaty.ts Outdated
Show outdated Hide outdated README.md Outdated

lijiarui added some commits Sep 15, 2017

@lijiarui lijiarui requested a review from zixia Sep 15, 2017

@zixia

Could you please make sure that you are just moving code blocks, without make any additional modifications?

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Sep 15, 2017

Member

Also add @private all deprecated APIs.

how do you think about it?

Member

lijiarui commented Sep 15, 2017

Also add @private all deprecated APIs.

how do you think about it?

@zixia zixia merged commit 7e6dc0f into Chatie:master Sep 15, 2017

4 of 6 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codeclimate All good!
Details
security/snyk No new issues
Details
@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Sep 15, 2017

Member

That's OK. Thanks!

Member

zixia commented Sep 15, 2017

That's OK. Thanks!

@lijiarui lijiarui deleted the lijiarui:change-doc-order branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment