Skip to content

Link preview always shows "link was not loaded" on hover over previous messages #2054

@fanway

Description

@fanway

Describe the bug
Link preview always shows "No link info loaded" on hover over previous messages, when you set Link information setting to enabled.

To reproduce

  1. Start app with Link information setting disabled
  2. Post message with a link (or recent-messages would do too)
  3. Enable setting, and it will always show "No link info loaded" on hover.

Chatterino version
Chatterino 2.2.2 (commit 8461318)

It happens because link information is fetched in TwitchMessageBuilder.cpp only once ( on message build :) )

this->addLink(string, linkString);

And setting is checked here
if (!getSettings()->linkInfoTooltip)
{
successCallback("No link info loaded", Link(Link::Url, url), nullptr);
return;
}

And it never gets updated afterwards. So you need to restart the app to get previous links resolved.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working as intended, or works in a confusing/unintuitive way for the user

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions