Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link preview always shows "link was not loaded" on hover over previous messages #2054

Closed
fanway opened this issue Oct 10, 2020 · 1 comment · Fixed by #2108
Closed

Link preview always shows "link was not loaded" on hover over previous messages #2054

fanway opened this issue Oct 10, 2020 · 1 comment · Fixed by #2108
Labels
bug Something isn't working as intended

Comments

@fanway
Copy link
Contributor

fanway commented Oct 10, 2020

Describe the bug
Link preview always shows "No link info loaded" on hover over previous messages, when you set Link information setting to enabled.

To reproduce

  1. Start app with Link information setting disabled
  2. Post message with a link (or recent-messages would do too)
  3. Enable setting, and it will always show "No link info loaded" on hover.

Chatterino version
Chatterino 2.2.2 (commit 8461318)

It happens because link information is fetched in TwitchMessageBuilder.cpp only once ( on message build :) )

this->addLink(string, linkString);

And setting is checked here
if (!getSettings()->linkInfoTooltip)
{
successCallback("No link info loaded", Link(Link::Url, url), nullptr);
return;
}

And it never gets updated afterwards. So you need to restart the app to get previous links resolved.

@fanway fanway added bug Something isn't working as intended needs triage labels Oct 10, 2020
@ALazyMeme
Copy link
Collaborator

Can reproduce.

  • Windows 10
  • Chatterino Nightly 2.2.2 (commit 9204089, 10.10.2020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
2 participants