-
-
Notifications
You must be signed in to change notification settings - Fork 524
Closed
Labels
bugSomething isn't working as intended, or works in a confusing/unintuitive way for the userSomething isn't working as intended, or works in a confusing/unintuitive way for the user
Description
Describe the bug
Link preview always shows "No link info loaded" on hover over previous messages, when you set Link information setting to enabled.
To reproduce
- Start app with
Link informationsetting disabled - Post message with a link (or recent-messages would do too)
- Enable setting, and it will always show "No link info loaded" on hover.
Chatterino version
Chatterino 2.2.2 (commit 8461318)
It happens because link information is fetched in TwitchMessageBuilder.cpp only once ( on message build :) )
| this->addLink(string, linkString); |
And setting is checked here
chatterino2/src/providers/LinkResolver.cpp
Lines 18 to 22 in 8532c6d
| if (!getSettings()->linkInfoTooltip) | |
| { | |
| successCallback("No link info loaded", Link(Link::Url, url), nullptr); | |
| return; | |
| } |
And it never gets updated afterwards. So you need to restart the app to get previous links resolved.
Metadata
Metadata
Assignees
Labels
bugSomething isn't working as intended, or works in a confusing/unintuitive way for the userSomething isn't working as intended, or works in a confusing/unintuitive way for the user