Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when moving split across windows #2249

Closed
sando opened this issue Dec 5, 2020 · 4 comments · Fixed by #2259
Closed

Crash when moving split across windows #2249

sando opened this issue Dec 5, 2020 · 4 comments · Fixed by #2259
Assignees
Labels
bug Something isn't working as intended crash

Comments

@sando
Copy link
Contributor

sando commented Dec 5, 2020

Describe the bug
A bit of a weird one here: if you popup a split, drag that split into another window, then close the popup window, a crash occurs.

To reproduce

  1. Popup a split (via CTRL+N)
  2. From the popup window, drag that split back into another window
  3. Close the window you dragged the split from
  4. Wait for it to crash - opening another tab seems to make this occur quickly

Screenshots
image

Chatterino version
Chatterino Nightly 2.2.3-beta2 (commit 9ebc448, ) (self-built)
Chatterino Nightly 2.2.3-beta2 (commit 05aab86, 22.11.2020)

Operating system
Windows 10 20H2 (OS Build 10942.662)

Additional information
This crash seems to appear in a few different places in code depending on the timing, but these are the two I've been able to capture trying to repro while filing this issue.
image
image
image

@sando sando added bug Something isn't working as intended needs triage labels Dec 5, 2020
@ALazyMeme
Copy link
Collaborator

Cannot reproduce: Windows 10 20H2 | commit a79081f

@pajlada
Copy link
Member

pajlada commented Dec 6, 2020

Can reproduce, looking into this now

@pajlada
Copy link
Member

pajlada commented Dec 6, 2020

@sando Could you please try this PR out to see if it fixes your issue? #2259

@sando
Copy link
Contributor Author

sando commented Dec 6, 2020

Can confirm #2259 fixes the issue. Tried the above example and a few other combinations of manipulating splits across windows, no crashes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended crash
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants