Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height of splits is not accurately loaded #2362

Closed
gempir opened this issue Jan 16, 2021 · 3 comments
Closed

Height of splits is not accurately loaded #2362

gempir opened this issue Jan 16, 2021 · 3 comments
Labels
bug Something isn't working as intended

Comments

@gempir
Copy link
Contributor

gempir commented Jan 16, 2021

Describe the bug
When having multiple splits in the same column so under another the sizes of these splits don't get saved into the config very accurately upon closing Chatterino.

Edit: They get saved correctly, Chatterino loads them and then changes them a bit for some reason and saves that new value into the config.

Maybe window size in general isn't saved very accurate either, because I think the width of my chatterino isn't saving perfectly either.

Filters are really useful and I use vertical splits a lot with them to have little mini chats below, that's why the accurate size is important to me. Currently I resize every time I start chatterino.

To reproduce
Create a tab with atleast 2 splits vertically. (So in 1 column)
Adjust the size for to a very small split and wait for the layout to save. Then close and reopen chatterino.

Screenshots
Before closing:
https://i.imgur.com/zMunuES.png

After Closing:
https://i.imgur.com/x3ubDTu.png

Chatterino version
Chatterino 2.2.3-beta2 (commit d0deb44)

Operating system
Manjaro 20.2.1 with i3

@gempir gempir added the bug Something isn't working as intended label Jan 16, 2021
@zneix
Copy link
Collaborator

zneix commented Jan 16, 2021

Can confirm, I'm having the same issue on Arch Linux 5.10.7, i3 4.19

@ALazyMeme
Copy link
Collaborator

I could've sworn this was already an issue. I've been having issues with sizing resetting for ages

@gempir gempir changed the title Height of splits is not accurately saved Height of splits is not accurately loaded Mar 20, 2021
@gempir
Copy link
Contributor Author

gempir commented Apr 17, 2021

Fixed in #2554

@gempir gempir closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants