Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added formatting for remaining timeout duration #2398

Merged
merged 11 commits into from Jan 31, 2021
Merged

Added formatting for remaining timeout duration #2398

merged 11 commits into from Jan 31, 2021

Conversation

M4tthewDE
Copy link
Contributor

@M4tthewDE M4tthewDE commented Jan 24, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Converts remaining timeout into more human readable form.
Not sure if this warrants a changelog entry. First pull request, feedback apreciated.

@zneix
Copy link
Collaborator

zneix commented Jan 24, 2021

I'd add a minor changelog entry in here, something along these lines: - Minor: Added human-readable formatting to remaining timeout duration. (#2398)

@pajlada
Copy link
Member

pajlada commented Jan 31, 2021

Thanks a lot for your contribution!
If you want to, you can make another PR adding yourself to the contributors.txt list to make your name show up in the Chatterino about page!
See https://github.com/Chatterino/chatterino2/blob/master/resources/contributors.txt#L1-L2

@pajlada
Copy link
Member

pajlada commented Jan 31, 2021

Waiting for #2426 to be merged in, then I'll get your branch up-to-date to master and then merge your branch into master

@pajlada pajlada merged commit c278266 into Chatterino:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants