Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheer emotes don't have feature parity with BTTV emotes. #2434

Closed
Mm2PL opened this issue Feb 3, 2021 · 1 comment · Fixed by #2503
Closed

Cheer emotes don't have feature parity with BTTV emotes. #2434

Mm2PL opened this issue Feb 3, 2021 · 1 comment · Fixed by #2503
Labels
bug Something isn't working as intended

Comments

@Mm2PL
Copy link
Collaborator

Mm2PL commented Feb 3, 2021

Describe the bug

Cheer emotes (Cheer1, Cheer10, pajaCheer1, etc.) cannot be zoomed in. You cannot open links to the GIF.

To reproduce

  1. Find a channel with people cheering.
  2. Hover over the cheer emote and see that it doesn't have a preview.
  3. Right click the emote and see that you cannot open the link in a browser.

Screenshots

N/A

Chatterino version

Chatterino + Dankerino patches 763acf9 based on upstream c278266

Operating system

Ubuntu 20.04.1 LTS (Focal Fossa)

Additional information

@Mm2PL Mm2PL added the bug Something isn't working as intended label Feb 3, 2021
@pajlada pajlada added the help wanted Help is wanted to debug/fix this issue label Feb 5, 2021
@jupjohn
Copy link
Contributor

jupjohn commented Mar 8, 2021

This is caused by the EmoteElement created for a bit cheer not having a valid Tooltip set when it's created. This means it fails the check in ChannelView.cpp#L1406 where the tooltip must not be empty.

@Felanbird Felanbird removed the help wanted Help is wanted to debug/fix this issue label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants