Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages from yourself that get caught by AutoMod don't show up in chat at all (it doesn't even tell you it was caught). #2626

Closed
auxtinn opened this issue Apr 14, 2021 · 26 comments · Fixed by #2744
Assignees
Labels
bug Something isn't working as intended

Comments

@auxtinn
Copy link

auxtinn commented Apr 14, 2021

Describe the bug:

Messages from yourself that get caught by AutoMod don't tell you that they were OR show up at all in the Chatterino chat client.

To reproduce:

Have a message get caught by AutoMod.

Screenshots:

Not Applicable.

Chatterino version:

Chatterino 2.2.3-beta2 (commit 59afb2b)

Operating system:

macOS Big Sur Version 11.2.3

macOS Big Sur Version 11.2.3

Additional information:

It should at least tell you that it was caught by AutoMod like it does in the native chat client. It doesn't even tell you that, and just doesn't post anything to chat.

@auxtinn auxtinn added the bug Something isn't working as intended label Apr 14, 2021
@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 14, 2021

Do you see who timed out users and the reasons? I suspect that your PubSub connection broke (#1022)

@auxtinn
Copy link
Author

auxtinn commented Apr 14, 2021

what do you mean? i'm talking about in channels where you're not a mod, if a message gets caught by AutoMod, it doesn't tell you your message was caught, nor does it say anything about it in chat, nor does it post it.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 14, 2021

I misread the issue, sorry.

Rel: #1710

@auxtinn
Copy link
Author

auxtinn commented Apr 14, 2021

I don't see that issue being related to this one.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 14, 2021

That issue is related because automod can drop messages kinda like the TMI bugs described there.

@auxtinn
Copy link
Author

auxtinn commented Apr 14, 2021

I see how you think that, but it's not about messages being dropped. They're still caught by AutoMod and sent to mods and the streamer but just not at all visible to you, the sender. I think it's just a feature that needs to be added.

@auxtinn auxtinn changed the title Messages caught by AutoMod don't show up in chat at all (it doesn't even tell you it was caught). Messages from yourself that get caught by AutoMod don't show up in chat at all (it doesn't even tell you it was caught). Apr 14, 2021
@jupjohn
Copy link
Contributor

jupjohn commented Apr 14, 2021

I don't believe this relates to the TMI bugs. This just seems like chatterino not handling when AutoMod catches a message. Currently there is no output so it appears like no message was sent. Definitely a feature.

@auxtinn
Copy link
Author

auxtinn commented Apr 15, 2021

I don't believe this relates to the TMI bugs. This just seems like chatterino not handling when AutoMod catches a message. Currently there is no output so it appears like no message was sent. Definitely a feature.

agreed.

@jupjohn
Copy link
Contributor

jupjohn commented Apr 16, 2021

Ignore me, this is a bug. I wasn't aware AutoMod messages were handled because I've never seen the message show up when message conflicts with AutoMod. Tested and finally saw the AutoMod message.

Related to the #1710

@auxtinn
Copy link
Author

auxtinn commented Apr 16, 2021

Ignore me, this is a bug. I wasn't aware AutoMod messages were handled because I've never seen the message show up when message conflicts with AutoMod. Tested and finally saw the AutoMod message.

Related to the #1710

what's the related?

@auxtinn
Copy link
Author

auxtinn commented Apr 17, 2021

have any chatterino developers seen this?

@zneix
Copy link
Collaborator

zneix commented Apr 17, 2021

have any chatterino developers seen this?

yes

@auxtinn
Copy link
Author

auxtinn commented Apr 18, 2021

have any chatterino developers seen this?

yes

is it being looked in-to?

@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 18, 2021

is this being looked into?

Yes

There is no notice from TMI that indicates a message is being held by automod

@auxtinn
Copy link
Author

auxtinn commented Apr 18, 2021

have any chatterino developers seen this?

yes

is it being looked in-to?

@zneix

@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 18, 2021

We (open source developers) have lives too, don't you know? We'll get to fixing the issue when we get to it.

@auxtinn
Copy link
Author

auxtinn commented Apr 20, 2021

We (open source developers) have lives too, don't you know? We'll get to fixing the issue when we get to it.

sorry.

@zneix
Copy link
Collaborator

zneix commented Apr 20, 2021

It's alright, however I don't think there's much we can do about it at this point. As Mm2PL mentioned, it's an issue with TMI (Twitch Messaging Interface) not giving us any response back.

@zneix zneix added the blocked Something out of our power needs to change before proceeding with this issue label Apr 20, 2021
@auxtinn
Copy link
Author

auxtinn commented Apr 20, 2021

It's alright, however I don't think there's much we can do about it at this point. As Mm2PL mentioned, it's an issue with TMI (Twitch Messaging Interface) not giving us any response back.

that's unfortunate :/

@apa420
Copy link
Collaborator

apa420 commented Apr 21, 2021

I might be wrong but isn't the "Your message has be caught by AutoMod" a pubsub message?
Considering other AutoMod messages are done with pubsub this might be the case here.
The pubsub connection might have dropped for one reason or another (it's very unreliable) so it might that.

@zneix
Copy link
Collaborator

zneix commented Apr 21, 2021

I might be wrong but isn't the "Your message has be caught by AutoMod" a pubsub message?
Considering other AutoMod messages are done with pubsub this might be the case here.
The pubsub connection might have dropped for one reason or another (it's very unreliable) so it might that.

Haven't had a look into pubsub, if anyone smarter than me with pubsub knows something about it please lmk.

@iProdigy
Copy link
Contributor

iProdigy commented May 3, 2021

I might be wrong but isn't the "Your message has be caught by AutoMod" a pubsub message?
Considering other AutoMod messages are done with pubsub this might be the case here.
The pubsub connection might have dropped for one reason or another (it's very unreliable) so it might that.

Haven't had a look into pubsub, if anyone smarter than me with pubsub knows something about it please lmk.

Yes;

{"type":"MESSAGE","data":{"topic":"chat_moderator_actions.53888434.53482260","message":"{\"type\":\"moderation_action\",\"data\":{\"type\":\"chat_targeted_login_moderation\",\"moderation_action\":\"automod_message_rejected\",\"args\":[\"ogprodigy\"],\"msg_id\":\"44ede2ad-c88e-4038-baee-1ae049437fff\",\"target_user_id\":\"53888434\",\"target_user_login\":\"\"}}"}}

edit: and on deny,
{"type":"MESSAGE","data":{"topic":"chat_moderator_actions.53888434.53482260","message":"{\"type\":\"moderation_action\",\"data\":{\"type\":\"chat_targeted_login_moderation\",\"moderation_action\":\"automod_message_denied\",\"args\":[\"ogprodigy\"],\"msg_id\":\"9dcfc0d7-3290-4501-9ee0-451fff4caff4\",\"target_user_id\":\"53888434\",\"target_user_login\":\"\"}}"}}

@apa420
Copy link
Collaborator

apa420 commented May 4, 2021

Are these pubsub messages sent when you are a normal viewer in a chat or a mod?
Afaik the automod pubsub messages only show up if you are a mod/broadcaster and this issue is about the normal user.

@Mm2PL
Copy link
Collaborator

Mm2PL commented May 4, 2021

Are these pubsub messages sent when you are a normal viewer in a chat or a mod?
Afaik the automod pubsub messages only show up if you are a mod/broadcaster and this issue is about the normal user.

Chat moderator actions are sent to normal users if they are the target of the action, that's how viewing your own timeout reasons works. So maybe this could work too.

@zneix zneix removed the blocked Something out of our power needs to change before proceeding with this issue label May 4, 2021
@iProdigy
Copy link
Contributor

iProdigy commented May 4, 2021

Are these pubsub messages sent when you are a normal viewer in a chat or a mod?
Afaik the automod pubsub messages only show up if you are a mod/broadcaster and this issue is about the normal user.

The example messages above are fired for normal users

& you're correct that the pubsub messages recieved do vary whether you are a mod or not. For example, instead of automod_message_rejected, mods recieve automod_rejected, which includes more data in args: {"type":"MESSAGE","data":{"topic":"chat_moderator_actions.493418343.53482260","message":"{\"type\":\"moderation_action\",\"data\":{\"type\":\"chat_login_moderation\",\"moderation_action\":\"automod_rejected\",\"args\":[\"ogprodigy\",\"shit\",\"profanity\"],\"created_by\":\"\",\"created_by_user_id\":\"\",\"created_at\":\"\",\"msg_id\":\"44ede2ad-c88e-4038-baee-1ae049437fff\",\"target_user_id\":\"53888434\",\"target_user_login\":\"ogprodigy\",\"from_automod\":false}}"}}

@apa420
Copy link
Collaborator

apa420 commented May 4, 2021

I'll take a look at this as well while I'm at it I guess

@apa420 apa420 self-assigned this May 4, 2021
GabeEddyT added a commit to GabeEddyT/chatterino2 that referenced this issue May 25, 2021
Release v2.3.2

- Major: New split for channels going live! /live. (Chatterino#1797)
- Minor: Added a message that displays a new date on new day. (Chatterino#1016)
- Minor: Hosting messages are now clickable. (Chatterino#2655)
- Minor: Messages held by automod are now shown to the user. (Chatterino#2626)
- Minor: Load 100 blocked users rather than the default 20. (Chatterino#2772)
- Bugfix: Fixed a potential crashing issue related to the browser extension. (Chatterino#2774)
- Bugfix: Strip newlines from stream titles to prevent text going off of split header (Chatterino#2755)
- Bugfix: Automod messages now work properly again. (Chatterino#2682)
- Bugfix: `Login expired` message no longer highlights all tabs. (Chatterino#2735)
- Bugfix: Fix a deadlock that would occur during user badge loading. (Chatterino#1704, Chatterino#2756)
- Bugfix: Tabbing in `Select a channel to open` is now consistent. (Chatterino#1797)
- Bugfix: Fix Ctrl + Backspace not closing colon emote picker. (Chatterino#2780)
- Bugfix: Approving/denying AutoMod messages works again. (Chatterino#2779)
- Dev: Migrated AutoMod approve/deny endpoints to Helix. (Chatterino#2779)
- Dev: Migrated Get Cheermotes endpoint to Helix. (Chatterino#2440)

# gpg: directory '/c/Users/gtroy/.gnupg' created
# gpg: keybox '/c/Users/gtroy/.gnupg/pubring.kbx' created
# gpg: Signature made Sun May 16 15:05:25 2021 EDT
# gpg:                using RSA key 16CA5983F9FDD6EB599AAA70911916E0523B22F6
# gpg: Can't check signature: No public key

# Conflicts:
#	src/widgets/settingspages/GeneralPage.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants