Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid link to global FFZ emote detail #2807

Closed
Supinic opened this issue May 22, 2021 · 2 comments · Fixed by #2808
Closed

Invalid link to global FFZ emote detail #2807

Supinic opened this issue May 22, 2021 · 2 comments · Fixed by #2808
Labels
issue-report An issue reported by a user.

Comments

@Supinic
Copy link

Supinic commented May 22, 2021

Describe your issue
Using the Open FFZ emote links action on a global FFZ emote currently opens a link without the emote ID, leading to a 404.

E.g.: Attempting to open the emote link for the AndKnuckles emote opens
https://www.frankerfacez.com/emoticon/-AndKnuckles - instead of https://www.frankerfacez.com/emoticon/24999-AndKnuckles.

OS and Chatterino Version
Windows 10, 2.2.3

@Supinic Supinic added the issue-report An issue reported by a user. label May 22, 2021
@mlnrDev
Copy link

mlnrDev commented May 22, 2021

i think this could be the problem:

auto id = EmoteId{jsonEmote.value("id").toString()};

compared to how the id is parsed for channel emotes:
auto id =
EmoteId{QString::number(jsonEmote.value("id").toInt())};

though i'm not proficient enough in C++ to be sure

@Mm2PL
Copy link
Collaborator

Mm2PL commented May 22, 2021

I'll look into this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-report An issue reported by a user.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants