Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of settings library #1908

merged 4 commits into from Aug 30, 2020


Copy link

@pajlada pajlada commented Aug 23, 2020

Pull request checklist:

  • was updated, if applicable


This version handles symlinks properly

Fixes #1856

@pajlada pajlada marked this pull request as ready for review August 23, 2020 11:52
@pajlada pajlada requested a review from fourtf August 23, 2020 12:09
@pajlada pajlada force-pushed the feature/update-settings-library-version branch from 6935c34 to 677f6f0 Compare August 23, 2020 12:32
Copy link
Member Author

pajlada commented Aug 23, 2020

Need to update to latest master of settings library again

Copy link

@fourtf fourtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will wait with merge until a new stable version is released

@pajlada pajlada self-assigned this Aug 30, 2020
@pajlada pajlada merged commit 9ae79e6 into master Aug 30, 2020
@pajlada pajlada deleted the feature/update-settings-library-version branch August 30, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Symlinked setting jsons get destroyed
2 participants