Argument parsing rework #1940
Argument parsing rework #1940
Conversation
Also moved check from BrowerExtension.cpp to Args.cpp as it is more relevant there and doesn't require passing arguments to a function in another file
|
Closing a stale issue? |
|
I suppose this should also disable settings from being changed and saved since they are not synced between instances? Another solution would be to use IPC to add a new window to the original chatterino instance |
Agree, it is ignoring saving layout to
Not sure what do you mean here, this doesn't create separate instances of chatterino - it only generates its own layout based on channels supplied in parameter while ignoring layout in |
I mean it might be good to extend this to the regular settings as well, not just the layout of the windows.
Right now (unless I am mistaken) running chatterino with |
There was a problem hiding this comment.
The --crash-recovery option should be hidden, see https://doc.qt.io/qt-5/qcommandlineoption.html#Flag-enum
As fourtf mentioned in the comments about, when chatterino has been launched with the --channels option, settings saving should also be disabled.
More open feedback: --channels foo,bar will now open two tabs with foo in the first tab, and bar in the second tab. This assumes Twitch channels, this should probably be specified somehow. And how the channels are opened should probably also be settable somehow.
random thoughts:
--twitchchannels foo,bar or --channels twitch:foo,twitch:bar
Maybe making the character inbetween change whether something opens in a new tab or not?
So maybe --channels foo+bar is a single tab with foo and bar horizontally split, and --channels foo/bar is vertically split? Not sure what characters are best to use.
If the "changing how channels are set up" ends up being too big, you're fine to implement that in a separate PR imo, just give a bit of thought to it so the , character can stay the same behaviour
|
I changed the way how you specify channels - it's now Also changed tab delimeter character to
This could be done, but handling multiple vertical and horiziontal splits in one tab is horrible and at this point I think it's a bit overcomplicated, so I don't know if I should try implementing multiple splits in one tab with more parsed JSON or just drop that altogether, wait for eventual rework of |
|
would prefer to use a character other than -, which could be part of a username atm. |
Previously, we were creating UI elements at while we were reading the window-layout.json file. We now read the window-layout.json file fully first, which results in a WindowLayout struct which is built up of a list of windows with a list of tabs with a root node which contains containers and splits. This WindowLayout can then be applied. This will enable PRs like #1940 to start Chatterino with Window Layouts that aren't defined in a json file. This commit has deprecated loading of v1 window layouts (we're now on v2). If a v1 window layout is there, it will just be ignored and Chatterino will boot up as if it did not have a window layout at all, and on save that old window layout will be gone.
…1964) * Split up Window Layout loading into a loading and application stage Previously, we were creating UI elements at while we were reading the window-layout.json file. We now read the window-layout.json file fully first, which results in a WindowLayout struct which is built up of a list of windows with a list of tabs with a root node which contains containers and splits. This WindowLayout can then be applied. This will enable PRs like #1940 to start Chatterino with Window Layouts that aren't defined in a json file. This commit has deprecated loading of v1 window layouts (we're now on v2). If a v1 window layout is there, it will just be ignored and Chatterino will boot up as if it did not have a window layout at all, and on save that old window layout will be gone. * Fix compile error for mac
|
I tried this and it works well, I use it in a script that runs streamlink and chatterino. |
|
Yeah, it is working fine with current code however I should get rid of JSON parsing and it is possible because #1964 is merged now. I just gotta rework that one bit and it will be good to go. I have to find some time in the week and I hope I can make it before this weekend. Thanks for approving though :) |
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Makes use of
QCommandLineParserand parses user input adding few dank features:--help:chatterino --channels pajlada,zneix,mm2plwill start chatterino, but only with those 3 channels open in each split. I think that comma as split character is fine since it can't be a part of twitch username.window-layout.json, saving in WindowManager is disabled when application was invoked with--channelsargument.Small TODO:
--channels- it works, but it still uses strings to parse JSON, maybe there's a better solution?Closes #43
Notes to take a look at before merging:
--helpgives you dialog window with help message, but--versiondoesn't show anything and quits - that was also a thing before, but we can fix it by using nativeaddVersionOptionmethod, however that will only output app name + version without commit, removing functionality added in Made --version argument output consistent with AboutPage #1739 which I don't wanna do.