Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-refresh UserInfoPopup recent messages #1982

Merged
merged 5 commits into from Sep 26, 2020
Merged

Auto-refresh UserInfoPopup recent messages #1982

merged 5 commits into from Sep 26, 2020

Conversation

dnsge
Copy link
Contributor

@dnsge dnsge commented Sep 24, 2020 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Automatically add new messages to UserInfoPopup dialogs as they are received without having to press the refresh button. Clicking refresh will load the latest messages again from the channel.

Video examples

Example 1
Example 2

@Mm2PL
Copy link
Collaborator

Mm2PL commented Sep 25, 2020

Messages in usercards are duplicated, probably because I have the same channel open in multiple splits. Please fix that 🙂

@dnsge
Copy link
Contributor Author

dnsge commented Sep 25, 2020

I couldn't reproduce the duplicated messages with having 2 of the same channel open. Could you upload a video of the issue?

fourtf
fourtf reviewed Sep 26, 2020
View reviewed changes
Copy link
Member

@fourtf fourtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signal doesn't get disconnected when the pop-up closes? Or am I seeing wrong

@fourtf
Copy link
Member

fourtf commented Sep 26, 2020

Looks good to me 👍 Thank you for your contribution!

@fourtf fourtf merged commit f7f858a into Chatterino:master Sep 26, 2020
@dnsge
Copy link
Contributor Author

dnsge commented Sep 26, 2020

@fourtf I was doing some testing and found that this->setAttribute(Qt::WA_DeleteOnClose); needs to be added in the constructor otherwise the window won't be deleted if closed by the x button.

@fourtf
Copy link
Member

fourtf commented Sep 26, 2020

@dnsge I'll push a fix in a sec

@zneix zneix mentioned this pull request Mar 12, 2021
Merged
1 task
@MrAuro MrAuro mentioned this pull request May 16, 2022
Merged
1 task
zneix pushed a commit that referenced this pull request May 17, 2022
@MrAuro
Removed unused refreshButton pointer (#3744)
28efd29 
Follow-up to #1982
@dnsge dnsge deleted the feature/usercard-autorefresh branch July 6, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@23rd 23rd 23rd left review comments

@fourtf fourtf fourtf left review comments

@leon-richardt leon-richardt leon-richardt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dnsge @Mm2PL @fourtf @23rd @leon-richardt