Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subage and followage to usercard #2023

Merged
merged 6 commits into from Oct 4, 2020
Merged

Added subage and followage to usercard #2023

merged 6 commits into from Oct 4, 2020

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented Oct 3, 2020

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

We are using Leppunen's API here to determine user's subage to the current channel and since that API call also returns followage information I decided to utilize that and save ourselves an extra Helix API call.
I also added new files specifying new class and methods for Ivr API, which can be very easily expanded with new methods in the future if we ever have to do that.

Examples:

Debian 10 with i3 https://cdn.zneix.eu/94oB8Ug.png
Debian 10 with KDE Plasma https://cdn.zneix.eu/V74TcCF.png

When I was coding I also saw couple unnecessary nitpicks which I fixed :)

Closes #1122
Closes #1145
Closes #1946

We are using Leppunen's API here to determine user's subage to the current channel and since that API call also returns followage information I decided to utilize that and save ourselves an extra Helix API call.
I also added new files specifying new class and methods for Ivr API, which can be very easily expanded with new methods in the future if we ever have to do that.
When I was coding I also saw couple unnecessary nitpicks which I fixed :)
@tolekk
Copy link

tolekk commented Oct 3, 2020

Great contribution 👍 Good job

@fourtf
Copy link
Member

fourtf commented Oct 4, 2020

Looks good to me 👍 Thank you for your contribution!

@fourtf fourtf merged commit 776ce8b into Chatterino:master Oct 4, 2020
@zneix zneix deleted the followage-subage-in-usercard-kkona branch October 4, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants