Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Login expired!" message #2029

Merged

Conversation

leon-richardt
Copy link
Collaborator

@leon-richardt leon-richardt commented Oct 4, 2020

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The message displayed when an OAuth token expires repeatedly lead to users asking about what they should do in order to fix it. This PR changes the error message in order to clarify that users need to re-add their account. Additionally, a link to the "Accounts" page is included in the message (see video).

Video: https://i.nuuls.com/v0qWI.mp4

leon-richardt and others added 4 commits October 4, 2020 15:57
Since this message occurs when the OAuth token becomes invalid, users
have to re-add their account in order to continue using the application.
The previous message did not make this clear enough, often leading to
confusion and questions by users.

This commit changes the system message to more clear about what the user
has to do, and adds a link that opens the "Accounts" page in the
preferences.
@fourtf
Copy link
Member

fourtf commented Oct 4, 2020

Looks good to me 👍 Thank you for your contribution!

@fourtf fourtf merged commit aff5949 into Chatterino:master Oct 4, 2020
@leon-richardt leon-richardt deleted the feature/better-login-expired-messsage branch October 4, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants