Improved textEdit placeholder #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also removed the tooltip from non-twitch channels
23rd
reviewed
Nov 3, 2020
pajlada
requested changes
Nov 4, 2020
Sure thing, resolved in e99b353 |
pajlada
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
[ ]CHANGELOG.mdwas updated, if applicablenot applicable
Description
I applied some suggestions about placeholder text being a bit too 'easily readable' and made it slightly lighter to not mix with color of system messages and message timestamps.
I also read that tooltip might've been causing some issues on non-twitch channels, so I removed it (though, it only makes sense in twitch channels anyway).