Updated minimum required Qt versions #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darn, I didn't notice #2208 before opening this PR. |
|
Duplicates #2208 but maybe this one is better |
|
Yeah, I like this one better, closing #2208 |
swills
pushed a commit
to swills/chatterino2
that referenced
this pull request
Nov 21, 2020
This updates both the build instructions and enforces qt version when running qmake
swills
pushed a commit
to swills/chatterino2
that referenced
this pull request
Nov 21, 2020
This updates both the build instructions and enforces qt version when running qmake
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
As discused on Chatterino Discord, we now have methods in our code such as QOalette#placeholderText in https://github.com/Chatterino/chatterino2/blob/master/src/widgets/splits/Split.cpp#L321-L322 which were introduced in Qt 5.12.0, updated documentation to reflect those changes.