Fixed "raw mentions" not being clickable with special characters appended to them #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many chat users often use "Copy full message" from message context menu and paste that in chat, which has format similar to "13:37 zneix: message xd" and it is pretty convinent to have it resolve to mention as well.
zneix
changed the title
pajlada
approved these changes
Nov 22, 2020
pajlada
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Made "raw-mentions" consistent with @mentions in setting bold usernames and being able display usercard by clicking. To achieve that, I added a second, simple regex; similar to
mentionRegex.https://cdn.zneix.eu/2LdNrGt.png
I also decided to add colon to special characters that will not have influence on not resolving usercard, because many chatters often use "Copy full message" from message context menu and paste that in chat, which has format similar to
13:37 zneix: message xdand it is pretty convenient to have it resolve to mention as well.