Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent to ChannelFilterEditorDialog #2232

merged 3 commits into from Nov 28, 2020


Copy link

@pajlada pajlada commented Nov 28, 2020

Pull request checklist:

  • was updated, if applicable


The ChannelFilterEditorDialog was missing a parent.
Fixes #2202

@pajlada pajlada force-pushed the fix/add-parent-to-channelfiltereditordialog branch from 94f68b7 to 5256ca3 Compare November 28, 2020 14:08
Copy link
Member Author

pajlada commented Nov 28, 2020

@leon-richardt Could you try this out on your sway setup?

Copy link

@leon-richardt leon-richardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on sway 👍

@pajlada pajlada merged commit 5258ddd into master Nov 28, 2020
@pajlada pajlada deleted the fix/add-parent-to-channelfiltereditordialog branch November 28, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

ChannelFilterEditorDialog Spawns in Tiling Mode
2 participants