Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make LoginWidget child of AccountsPage #2234

Merged

Conversation

leon-richardt
Copy link
Collaborator

@leon-richardt leon-richardt commented Nov 28, 2020

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Another followup to #1843, this time regarding the LoginWidget spawned when adding a new account.

This is necessary in order to guarantee correct (i.e. floating) window
positioning on some window managers, e.g. sway.
@leon-richardt leon-richardt marked this pull request as ready for review November 28, 2020 18:09
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me on i3 using Arch Linux btw 👍

@pajlada pajlada merged commit 0a0cfb8 into Chatterino:master Nov 29, 2020
@leon-richardt leon-richardt deleted the fix/login-dialog-has-no-parent branch November 29, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants