Further placeholder text fixes #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an event listener for `channelChanged` signal. Moved entire function related to applying placeholder's color to SplitInput.cpp to ensure it will be applied in all cases, preventing random edge cases listed in Chatterino#2253. In that file, I also changed `QPalette::Foreground` enum to `QPalette::WindowText` due to deprecation warning in Qt 5.13: https://doc.qt.io/qt-5/qpalette.html#ColorRole-enum
pajlada
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
channelChangedsignal to ensure placeholder is preserved when changing channels.SplitInput.cppI also changedQPalette::Foregroundenum toQPalette::WindowTextdue to deprecation warning since Qt 5.13.Closes #2253