Improve the "You are banned" message #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds special case for being force PARTed off a channel which happens when getting banned, but does not mean being banned.
|
@pajlada, could you please review this? |
leon-richardt
approved these changes
Dec 8, 2020
zneix
requested changes
Dec 9, 2020
Applied suggestion to the wrong part of the code
Mm2PL
force-pushed
the
feature/banned_message
branch
from
c1198cd
to
fde5c81
Compare
|
I attempted to fix my own fork and force pushed on the wrong branch :-) |
Co-authored-by: Paweł <zneix@zneix.eu>
zneix
approved these changes
Dec 9, 2020
pajlada
approved these changes
Dec 12, 2020
|
@Mm2PL Looks good to me! Please get this branch up-to-date with master and I'll merge this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Closes #2110
Adds:
Link::ReconnectRemoves:
Changes
Notes
An unexpected
PARTdoesn't exactly mean being banned. If you get banned you get a Pubsub message saying that you were after thePART.Screenshots