Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated follow and unfollow methods to Helix API #2306

Merged
merged 3 commits into from Dec 22, 2020
Merged

Migrated follow and unfollow methods to Helix API #2306

merged 3 commits into from Dec 22, 2020

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented Dec 21, 2020 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Moved place of declared Kraken methods from TwitchAccount class to Helix class. Updated api documentation accordingly

pajlada
pajlada requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks, other than that looks great! Thanks a lot for your contribution!

src/controllers/commands/CommandController.cpp Show resolved Hide resolved
src/controllers/commands/CommandController.cpp Show resolved Hide resolved
@zneix zneix requested a review from pajlada December 21, 2020 23:08
@pajlada pajlada merged commit 2f5df3d into Chatterino:master Dec 22, 2020
@zneix zneix deleted the feature/migreated-follow-unfollow-to-helix branch December 22, 2020 11:35
@zneix zneix mentioned this pull request Dec 22, 2020
Merged
pajlada pushed a commit that referenced this pull request Dec 24, 2020
@zneix @pajlada
Migrated follow and unfollow methods to Helix API (#2306)
f8aec3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zneix @pajlada