Added /chatters command #2344
Merged
Added /chatters command #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23rd
reviewed
Jan 8, 2021
23rd
reviewed
Jan 8, 2021
Since we still support Qt 5.12.10, I will leave this unchanged, as build fails on 5.12 and deprecation warning is present on Qt 5.15
pajlada
requested changes
Jan 16, 2021
pajlada
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
As described in #2343, this is meant to replicate BetterTTV extension's behavoir and make use of the
chatter_countproperty we're reciving while fetching data from TMI API. If the approach I chose isn't the best, let me know how can I change it.While I was at it, I replaced deprecated
QString::SkipEmptyLineswith corresponding updated version fromQtnamespaceCloses #2343