Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated cheermotes to Helix API #2440

merged 9 commits into from May 15, 2021


Copy link

@zneix zneix commented Feb 7, 2021

Pull request checklist:

  • was updated, if applicable


Migrates Kraken's Get Cheermotes to its Helix equivalent.

(Finally) Closes #1928

Copy link


Copy link
Collaborator Author

zneix commented Apr 22, 2021


yes, I forgot about this stream content PR, will get to work on it

@pajlada pajlada force-pushed the feature/migrate-cheermotes branch from e4409d0 to bbc9e72 Compare May 15, 2021 11:08
Copy link

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested qmake builds, but if that works I'm good with this change 👌 Merge when you've had a change to review/approve my additions @zneix

Copy link
Collaborator Author

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request seems fine, thank you so much pajlada for finishing the parsing in it.
The only thing to note for the future is that naming of cheermotes is now inconsistent in the codebase as old code still calls them "cheerEmotes".

@zneix zneix marked this pull request as ready for review May 15, 2021 16:41
@zneix zneix enabled auto-merge (squash) May 15, 2021 16:56
@zneix zneix merged commit 519855d into Chatterino:master May 15, 2021
@zneix zneix deleted the feature/migrate-cheermotes branch May 15, 2021 17:09
vaehx added a commit to vaehx/chatterino2 that referenced this pull request May 16, 2021
* chatterino/master:
  Add setting to disable custom ffz mod/VIP badges (Chatterino#2759)
  added try catch in nm (Chatterino#2785)
  Fixed deprecated method Qt::SystemLocaleLongDate (Chatterino#2784)
  Migrated cheermotes to Helix API (Chatterino#2440)
  Fix word backspacing not closing/updating colon emote picker (Chatterino#2781)
  Load 100 blocked users instead of default 20 (Chatterino#2772)
  Refactored and Migrated to Helix AutoMod message management (Chatterino#2779)
  Add flatpak version badge (Chatterino#2782)
  Bump dangoslen/changelog-enforcer from 2.1.0 to 2.2.0 (Chatterino#2770)
  Bump ilammy/msvc-dev-cmd from 1.7.0 to 1.8.0 (Chatterino#2769)
GabeEddyT added a commit to GabeEddyT/chatterino2 that referenced this pull request May 25, 2021
Release v2.3.2

- Major: New split for channels going live! /live. (Chatterino#1797)
- Minor: Added a message that displays a new date on new day. (Chatterino#1016)
- Minor: Hosting messages are now clickable. (Chatterino#2655)
- Minor: Messages held by automod are now shown to the user. (Chatterino#2626)
- Minor: Load 100 blocked users rather than the default 20. (Chatterino#2772)
- Bugfix: Fixed a potential crashing issue related to the browser extension. (Chatterino#2774)
- Bugfix: Strip newlines from stream titles to prevent text going off of split header (Chatterino#2755)
- Bugfix: Automod messages now work properly again. (Chatterino#2682)
- Bugfix: `Login expired` message no longer highlights all tabs. (Chatterino#2735)
- Bugfix: Fix a deadlock that would occur during user badge loading. (Chatterino#1704, Chatterino#2756)
- Bugfix: Tabbing in `Select a channel to open` is now consistent. (Chatterino#1797)
- Bugfix: Fix Ctrl + Backspace not closing colon emote picker. (Chatterino#2780)
- Bugfix: Approving/denying AutoMod messages works again. (Chatterino#2779)
- Dev: Migrated AutoMod approve/deny endpoints to Helix. (Chatterino#2779)
- Dev: Migrated Get Cheermotes endpoint to Helix. (Chatterino#2440)

# gpg: directory '/c/Users/gtroy/.gnupg' created
# gpg: keybox '/c/Users/gtroy/.gnupg/pubring.kbx' created
# gpg: Signature made Sun May 16 15:05:25 2021 EDT
# gpg:                using RSA key 16CA5983F9FDD6EB599AAA70911916E0523B22F6
# gpg: Can't check signature: No public key

# Conflicts:
#	src/widgets/settingspages/GeneralPage.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Migrate more endpoints from V5 to Helix
3 participants