fix: no longer crash on clip creation in "special" channels #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clip creation via the `Alt+X` shortcut failed for the `/mentions` and `/whispers` channel. This happened because `Channel::isTwitchChannel` returns `true` for these channels. (Internally, the types are `Channel::Type::TwitchMentions` and `Channel::Type::TwitchWhispers` in anticipation of supporting more platforms in the future.) This lead to a false assumption in the clip creation logic: Not all channels that display "Twitch content" are able to create clips. The employed fix checks the channel type in more detail. Clip creation is only allowed if the channel is `Channel::Type::Twitch` or `Channel::Type::TwitchWatching`. This makes sure that there always is an associated channel to generate a clip from. Additional note: Clip creation did not crash when initiated via the `/clip` command. This is due to the fact that `CommandController::execCommand` makes additional checks regarding the channel context before executing the command.
leon-richardt
force-pushed
the
fix/crash-on-clip-creation
branch
from
52705a8
to
6e2fc72
Compare
zneix
approved these changes
Mar 15, 2021
pajlada
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixes #2527.
Clip creation via the
Alt+Xshortcut failed for the/mentionsand/whisperschannel. This happened becauseChannel::isTwitchChannelreturnstruefor these channels. (Internally, the types areChannel::Type::TwitchMentionsandChannel::Type::TwitchWhispersin anticipation of supporting more platforms in the future.)This lead to a false assumption in the clip creation logic: Not all channels that display "Twitch content" are able to create clips.
The employed fix checks the channel type in more detail. Clip creation is only allowed if the channel is
Channel::Type::TwitchorChannel::Type::TwitchWatching. This makes sure that there always is an associated channel to generate a clip from.Additional note: Clip creation did not crash when initiated via the
/clipcommand. This is due to the fact thatCommandController::execCommandmakes additional checks regarding the channel context before executing the command.