Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app data dir not opening on macOS when "Open AppData" button pressed #2537

Merged
merged 4 commits into from Mar 20, 2021

Conversation

jupjohn
Copy link
Contributor

@jupjohn jupjohn commented Mar 18, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This PR aims to fix chatterino's app data directory not opening on macOS when pressing the "Open AppData..." button. When pressing the button on Windows/Linux the relevant directory is opened in the file explorer. When attempting to do this on macOS Finder does not open up the expected directory of $HOME/Library/Application Support/chatterino.

This is caused by macOS requiring file:// prior to the path in order for it to be opened in finder.

Fixes #2531

Copy link
Collaborator

@leon-richardt leon-richardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that it does not introduce a regression on a Linux/xdg-open/Nautilus setup 👍 (Cannot test on macOS unfortunately)

Check review comments for two small suggestions

src/widgets/settingspages/GeneralPage.cpp Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍 Thanks for the fix!

@pajlada pajlada merged commit 79bc700 into Chatterino:master Mar 20, 2021
@jupjohn jupjohn deleted the bugfix/2531-macos-open-appdata branch March 27, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS Open AppData dir broken
3 participants