Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented bit emotes #2550

merged 5 commits into from Mar 21, 2021


Copy link

@zneix zneix commented Mar 20, 2021

Pull request checklist:

  • was updated, if applicable


This pull request adds support for "Tabbing" and picking Bit emotes from emote picker menu. Also works with the "colon-emote-picker". To get this to work, we make a request to the Ivr API directly from chatterino - maybe I will have to redo it to make a request via chatteirno/api, however I didn't want to complicate things this much. Currently, emotes are refreshed every 10 minutes in TwitchEmotes::loadUserstateEmotes.

Little To-Do

  • Reload bit emotes on F5
    if there'll be any need for that, may be a part of another PR
    - [ ] Move emoteset fetching to chatteirno/api explained below
  • Decide whether or not to refresh emotes periodically
    decided this is fine

Would close #1450 #2183 #2388

Copy link
Collaborator Author

zneix commented Mar 21, 2021

As for caching emotes in chatterino/api, I think this is not needed since for regular emotes, we make a direct Kraken call and then contact chatterino/api only to get emote set data, (example). We also contact Ivr API to get emote data, however it already gives us info which we would normally need to request via chatterino/api, so I think it's fine as it is now.
Maybe, we can in the future move the call for emtoes in general to chatterino/api, but that's out of scope of the current pull request.

@pajlada pajlada merged commit 1f5b62e into Chatterino:master Mar 21, 2021
@zneix zneix deleted the feature/implement-bit-emotes branch March 21, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Include Bit emotes in the Emote Menu
2 participants