Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash that could occur when the user changed the "Custom stream player URI Scheme" setting if the user had closed down and splits in the application runtime #2592

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 4, 2021

  • Manage connections for the customURIScheme setting
  • Add changelog entry

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The connection listening to customURIScheme was not being handled properly - it now is

@pajlada pajlada requested a review from fourtf April 4, 2021 13:33
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to reproduce the crash once on master, however after checking out to this pull request it doesn't happen anymore 👍

@pajlada pajlada force-pushed the bugfix/customURIScheme-crashes-chatterino-if-tabs-or-splits-have-been-closed-in-the-lifetime-of-the-application branch from 8dfa366 to ec4f8dd Compare April 17, 2021 09:35
@pajlada pajlada enabled auto-merge (squash) April 17, 2021 09:36
@pajlada pajlada merged commit 8641435 into master Apr 17, 2021
@pajlada pajlada deleted the bugfix/customURIScheme-crashes-chatterino-if-tabs-or-splits-have-been-closed-in-the-lifetime-of-the-application branch April 17, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants