Made left-clicking splitheader focus split #2720

zneix · 2021-04-30T11:07:02Z

Pull request checklist:

CHANGELOG.md was updated, if applicable

Description

Simple fix, based on

chatterino2/src/widgets/splits/Split.cpp

Lines 157 to 159 in 9c41adc

    
           this->view_->mouseDown.connect([this](QMouseEvent *) { 
        
               this->giveFocus(Qt::MouseFocusReason); 
        
           });

pajlada

Looks good to me! I'll get this merged in today 👍

zneix added 2 commits April 30, 2021 13:06

Made left-clicking splitheader focus split

232cc0c

Added changelog entry

a8e4951

pajlada approved these changes May 1, 2021

View reviewed changes

pajlada enabled auto-merge (squash) May 1, 2021 13:53

Merge branch 'master' into zneix/fix/focus-split-on-splitheader-click

4eb0ffe

pajlada merged commit 6c9fd4f into master May 1, 2021

pajlada deleted the zneix/fix/focus-split-on-splitheader-click branch May 1, 2021 14:14

Made left-clicking splitheader focus split #2720

Made left-clicking splitheader focus split #2720

zneix commented Apr 30, 2021

pajlada left a comment

	this->view_->mouseDown.connect([this](QMouseEvent *) {
	this->giveFocus(Qt::MouseFocusReason);
	});

Made left-clicking splitheader focus split #2720

Made left-clicking splitheader focus split #2720

Conversation

zneix commented Apr 30, 2021

Description

pajlada left a comment

Choose a reason for hiding this comment